search

swarrot / SwarrotBundle

A symfony bundle for swarrot integration
MIT License
89 stars 59 forks source link

Allow new swarrot/swarrot version #110

Closed olaurendeau closed 7 years ago

olaurendeau commented 7 years ago

Answer https://github.com/swarrot/SwarrotBundle/issues/108 May should we discuss about removing SwarrotBundle php < 7.1 compatibility ?

odolbeau commented 7 years ago

Good question. I think there isn't a lot of hack to handle different PHP version in the bundle. Maybe we should discuss about bumping the minimal symfony version required to run this bundle (and change the PHP version according to this decision)?

olaurendeau commented 7 years ago

Indeed @stof I've been confused by the others requirements :) My intent was to allow swarrot/swarrot from >= 2.1.1 & < 4.0.0 does it sounds right ?

olaurendeau commented 7 years ago

BTW @odolbeau I don't have write right on SwarrotBundle :)

odolbeau commented 7 years ago

@olaurendeau corrected. :)