swarrot / SwarrotBundle

A symfony bundle for swarrot integration
MIT License
89 stars 59 forks source link

Add parameters for connection for PECL #137

Closed eguilly closed 6 years ago

eguilly commented 6 years ago

We need to pass the following parameters in the configuration of the connection for PECL:

Default values founds at :

Thanks for reviewing

odolbeau commented 6 years ago

Hi @eguilly!

As described in the README, all connections should now be defined with an url. I planned to make those connection parameters obsolete in a future version but I don't have a lot of time right now...

Instead of adding new config keys, you should instead update the UrlParserTrait to extract those new parameters and use them in the correct Factory (in your case PeclFactory).

Does it makes sense for you?

eguilly commented 6 years ago

Yes it is perfect. I had not seen for the url. I made the changes.

odolbeau commented 6 years ago

Looks good, thanks! :)