search

swarrot / SwarrotBundle

A symfony bundle for swarrot integration
MIT License
89 stars 59 forks source link

dot in messages-types are lost in the command help #153

Closed lyrixx closed 5 years ago

lyrixx commented 5 years ago

For exemple:

swarrot:
    messages_types:
        crawler.update_db:
            exchange: 'redirectionio'
            routing_key: 'crawler.update_db'

but the --help give that:

Description:
  Consume message of type "crawler_update_db" from a given queue

The dot has been replaced by and underscore

odolbeau commented 5 years ago

You're mixing message_types & consumers.

In your example, I bet your consumer is called crawler_update_db & not crawler.update_db. Calling it crawler.update_db works but having a dot in command names is not really beautiful.

What's wrong here is the description of the consumer command. This command don't know which message type you'll consume. I updated command description & help in #157