search

swarrot / SwarrotBundle

A symfony bundle for swarrot integration
MIT License
89 stars 59 forks source link

Add ServicesResetterProcessorConfigurator (closes #170) #171

Closed pvgnd closed 4 years ago

pvgnd commented 4 years ago

Just a work in progress for now to propose an implementation.

Still have tests to write

pvgnd commented 4 years ago

@odolbeau, @lyrixx could you have a look on the proposed implementation please ? (still WIP as tests have not been written yet)

odolbeau commented 4 years ago

This processor should not be put in the bundle but in https://github.com/swarrot/swarrot instead. Otherwise, it looks like a promising start, thanks for your work! :)

lyrixx commented 4 years ago

Thanks :+1:

pvgnd commented 4 years ago

OK, I will move Processor into https://github.com/swarrot/swarrot

pvgnd commented 4 years ago

@odolbeau could you have a look please ?

odolbeau commented 4 years ago

Looks great! Could you squash your commits please?

As swarrot 1.7.0 have been released it will allow us to check test at the same time. :)

pvgnd commented 4 years ago

Done

odolbeau commented 4 years ago

Perfect, thanks!