Port cannot be configured by env var

pvgnd commented 3 years ago

As the ENV var is resolved at runtime, port is casted into int by the bundle configuration class: https://github.com/swarrot/SwarrotBundle/blob/master/DependencyInjection/Configuration.php#L90

Configuration used:

swarrot:
    connections:
        event:
          host: '%env(APP_MESSAGE_BROKER_HOST)%'
          port: '%env(APP_MESSAGE_BROKER_PORT)%'
          login: '%env(APP_MESSAGE_BROKER_LOGIN)%'
          password: '%env(APP_MESSAGE_BROKER_PASSWORD)%'

bash-5.0$ php bin/console debug:config swarrot

Current configuration for extension with alias "swarrot"
========================================================

swarrot:
    connections:
        event:
            host: '%env(APP_MESSAGE_BROKER_HOST)%'
            port: 0
            login: '%env(APP_MESSAGE_BROKER_LOGIN)%'
            password: '%env(APP_MESSAGE_BROKER_PASSWORD)%'

odolbeau commented 3 years ago

Hi @pvgnd and thanks or this bug report. I strongly advise you to use the FQDN instead:

swarrot:
    connections:
        rabbitmq:
            url: "amqp://%rabbitmq_login%:%rabbitmq_password%@%rabbitmq_host%:%rabbitmq_port%/%rabbitmq_vhost%"

It will be easier to configure the FQDN per environment and you won't have this cast problem anymore.

I thought we depreciated the connection as array configuration when we introduced the FQDN configuration but it's not the case. :/

pvgnd commented 3 years ago

Good to know ! Thanks @odolbeau

swarrot / SwarrotBundle

Port cannot be configured by env var #207