what is the goal of extras in the messages_types config

swarrot / SwarrotBundle

A symfony bundle for swarrot integration

MIT License

89 stars 59 forks source link

what is the goal of extras in the messages_types config #44

Closed stof closed 7 years ago

stof commented 9 years ago

The messages_types feature is missing some documentation. For instance, the config defines an array extras, but I cannot find where it is used

odolbeau commented 9 years ago

It's used to configure some options in the SwarrotCommand. It's definitively not very useful except if you define your own default SwarrotCommand and if you need to change the behavior.

For example, we have 3 commands to consume messages. default, aws & payment. Each of them can have different retry strategies based on the extras configuration key.

You're right, the documentation (& tests) definitively need some love. :/

stof commented 9 years ago

Should this array be considered as a map or as a sequence ? The current configuration tree considers it as a sequence, which means keys are lost in case multiple files need to be merged (there is a bug in Symfony which does not reset the keys in case no merging is necessary)