Make the logger configurable everywhere

swarrot / SwarrotBundle

A symfony bundle for swarrot integration

MIT License

89 stars 59 forks source link

Closed odolbeau closed 8 years ago

odolbeau commented 8 years ago

Fix #82

lyrixx commented 8 years ago

You forgot an update in the changelog / upgrade file

lyrixx commented 8 years ago

:+1:

sroze commented 8 years ago

You don't have any test on the logger node that you are introducing, but only on your legacy publisher_logger node. Could you add one?

odolbeau commented 8 years ago

Tests updated. :)

sroze commented 8 years ago

It looks like symfony/phpunit-bridge drop the PHP 5.3 support so the tests are broken @odolbeau... :/

odolbeau commented 8 years ago

Fixed now @sroze!

sroze commented 8 years ago

Looks good then :+1: