Should BlackholePublisher publish events as well?

swarrot / SwarrotBundle

A symfony bundle for swarrot integration

MIT License

89 stars 59 forks source link

Should BlackholePublisher publish events as well? #87

Open marcw opened 8 years ago

marcw commented 8 years ago

I currently want to inspect messages that have been sent during my tests, without messages reaching my real broker. It's not possible out of the box as the BlackholePublisher does not collect data and is not plugged to the event dispatcher.

Before working on a patch, I want to be sure that it doesn't break the event dispatching meaning if events are sent from the BlackholePublisher.

Any thoughts on that matter?

odolbeau commented 8 years ago

We have the (near) the same need and we use a custom publisher which is a kind of stub. It's totally linked to our "business" logic as we read the message content to check that we dispatched the expected one.

Anyway, dispatching the event inside the BlackholePublisher don't seems to be a problem IMO.

As you created it, what's your opinion @blaugueux?