add factory for sqs provider

swarrot / SwarrotBundle

A symfony bundle for swarrot integration

MIT License

89 stars 59 forks source link

add factory for sqs provider #92

Closed nicolasThal closed 4 years ago

nicolasThal commented 8 years ago

In the configuration, the provider can be set to sqs.

For the other keys :

region is used to determine the aws region for the sqs instance
host determine the access url for the sqs instance

This pr is linked to https://github.com/swarrot/swarrot/pull/134

odolbeau commented 8 years ago

Instead of re-using existing keys, is it possible to use new ones for this provider only? :)

nicolasThal commented 7 years ago

@odolbeau @stof I have updated the pr with your reviews

odolbeau commented 7 years ago

@stof Do you have an example somewhere of how to have a different array prototype according to the key? Not sure if I'm really clear. :/ Here, it could be really cool to change the keys needed according to the provider your using (host, port & co for amqp vs login, pwd, region for aws).

Nicofuma commented 7 years ago

Hi, any update on this? Are you still working on it and how can I help?

odolbeau commented 7 years ago

Ping @nicolasThal?

nicolasThal commented 7 years ago

Hello,

Sorry for the late answer, I forgot it as I saw the notification during my hollidays.

Have you any ideas on how to improve the configuration declaration according to @odolbeau remarks ?

Swahjak commented 6 years ago

I don't see a way of implementing the configuration without a BC break. Looking at https://github.com/php-enqueue/enqueue-dev/blob/master/docs/bundle/config_reference.md could give some ideas.

odolbeau commented 4 years ago

SQS have been deprecated in swarrot.