search

swaruplabUCI / ArchRtoSignac

An R package performing object conversion from ArchRProject (ArchR) to Signac SeuratObject (Signac)
MIT License
32 stars 11 forks source link

Customized UMAP name and IterativeLSI request #20

Closed Sky970415 closed 11 months ago

Sky970415 commented 1 year ago

Hi @rootze, Could you please change the addDimRed() with customized UMAP names and IterativeLSI names? Sometimes the name for those are not default. If you could use [[addUMAPs]] instead of the hard coded $, it would be great.

Thanks, Jiakang

rootze commented 1 year ago

@Sky970415 Hello Jiakang, Thanks for using the ArchRtoSignac package and making a great suggestion. I am currently on vacation, so I won't be able to help you promptly. If you want to create an additional function, addcustomizedDimRed(), and create a pull request, I am more than happy to pull it and make it a part of this package. Thank you!

rootze commented 1 year ago

@Sky970415 Hello Jiakang. Thanks for creating the pull request. I will review the code and pull the request later. I'm in the midst of another project, so please allow me a week or so to finish the testing. Thank you again.

rootze commented 11 months ago

Request pulled, issue closed, thank you.