swaschkut / pan-os-php

Framework and utilities to easily manage and edit Palo Alto Network PANOS devices
ISC License
18 stars 1 forks source link

group-tag-Set action is failing #14

Closed ngfw-automation closed 5 months ago

ngfw-automation commented 6 months ago

I get an error when I try to set a group tag. This does not seem to depend on a filter. Here is an example command I run:

pan-os-php type=rule in=api://panorama address location=device group name 'filter=!(group-tag is.set) and (rule is.prerule)' 'actions=group-tag-Set:tag'

When executed with action display - it executes successfully, listing correct rules from the device group. However, when the action is swapped to the group-tag-Set, I get the error as follows:

processing ruleset 'PanoramaConf: / DeviceGroup:device group name / RuleStore:Security' that holds 301 rules

pan-os-php version

(running in Docker under WSL in Windows 10)

swaschkut commented 6 months ago

Thanks for finding this Bug and sharing it with me.

I already tried to fix it just in time, but it looks like that this is a longer part than just a few minutes.

Please be patient, I will fix this at the beginning of June. Thanks for your understanding.

ngfw-automation commented 6 months ago

Thank you, Sven.

Can you tell me in which version this functionality stopped working? I know for a fact that this action worked well before but since I always use the "latest" tag, it's now difficult to figure out which version I'd need to roll back to to recover this particular function.

(I have a lot of tagging to do hence the question)

swaschkut commented 5 months ago

you are totally right,

with version 2.1.16 I did some changes. your stuff was working from version 2.0.75 including 2.1.15;

docker run --name panosphp --rm -v ${PWD}:/share -it swaschkut/pan-os-php:2.1.15

should still work for you. I am closure to the real issue and will fix it this week

swaschkut commented 5 months ago

a fixed version is now available:

docker run --name panosphp --rm -v ${PWD}:/share -it swaschkut/pan-os-php:develop

it will be published soon in version 2.1.24

swaschkut commented 5 months ago

bugfix published with #16