Closed FullstopCoding closed 6 years ago
Merging #2 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 85 85
Branches 19 19
=====================================
Hits 85 85
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a3981fe...3f3c829. Read the comment docs.
Hi,
Thanks for the contribution. How exactly did you make the theme? I don't see any color scheme added to the schemes. What you need to do is
AyuDarkOrange.js
file.AyuDarkOrange.js
file.'Ayu Dark Orange': require('./schemes/AyuDarkOrange')
at the end of the list.yarn install && yarn build
.So you shouldn't edit themes/Ayu Dark Orange-color-theme.json
by hand as it should be autogenerated.
Ah...I just took a copy of your Ayu Dark theme and modified the colours, and then modified the packages.json file to include my JSON file!
Better, you copy src/schemes/AyuDark.js
to src/schemes/AyuDarkOrange.js
and make changes over there and do the steps above.
The theme files are not really hand-made. Those are just generated through a simple build https://github.com/swashata/vscode-beautiful-ui/blob/master/script/generateTheme.js
Hey, I just published a bunch of new themes. Also fixed some issues with the old ones. Can you please rebase your work with the new changes if you are still interested.
It looks like items in my theme use very specific colours for the tokens. Do I just explicitly state all the tokens for the theme?
Hi,
With current build system that isn't possible 🙁. I will change it a bit to accept specified token colors and override the existing ones. Let's give it a look over next weekend
Hi,
After giving thought, I think it is best if you publish your theme separately. The color patterns are too much different from what this engine gives.
If you need help publishing your theme, do let me know.
Apologies for some of the formatting (VS Code addon I'm sure), but here is another theme for the addon based on teabyii's Ayu Dark.