search

swashata / vscode-beautiful-ui

A set of beautiful color themes for VSCode, inspired by Sublime DA UI.
https://vscbui.rocks/
MIT License
60 stars 7 forks source link

Something seems... bolder #23

Closed jacobwgillespie closed 4 years ago

jacobwgillespie commented 4 years ago

Hi, first thank you so much for this awesome collection of themes! 🎉

One question, and it's possible that this is something misconfigured on my end - after upgrading to v1.5.0, certain keywords seem a lot bolder than before, almost too bold, and feels kinda heavy.

For example, here's a screenshot of the website preview next to the editor with the same contents:

Screenshot 2020-03-17 at 08 57 46 (2)

Was this an intentional change? Is something broken on my end? I believe the upgrade to 1.5.0 is the culprit, though my VS Code updated itself as well.

swashata commented 4 years ago

Hi,

The website is using shiki which doesn't do bold and italics on the preview.

But you are absolutely correct about the boldness. I was thinking about this too. The bold seems too much. I don't know if this is something to do with semantic highlighting or new vscode text rendering, but it certainly isn't easy on eyes. So I will revert the bold in the next update.

swashata commented 4 years ago

Also do try this https://superuser.com/questions/1437445/why-vscode-fonts-always-look-bold-in-macos

swashata commented 4 years ago

So I have released new version 1.6.0 and removed the bold styles completely (except from markdown bold). Also I have tweaked a few color tokens to make things more consistent. Do check it out and let me know.

jacobwgillespie commented 4 years ago

Thank you again, that fixed it! 🎉 ❤️