search

swashata / vscode-beautiful-ui

A set of beautiful color themes for VSCode, inspired by Sublime DA UI.
https://vscbui.rocks/
MIT License
60 stars 7 forks source link

Remove editorOverviewRuler styles #3

Closed ColCh closed 6 years ago

ColCh commented 6 years ago

VSCODE defines own colors for rules

https://github.com/Microsoft/vscode/blob/749eb1ebcd536083627f90c7e7abd14b1ef94af3/src/vs/editor/common/view/editorColorRegistry.ts#L56-L59

and it has different colors for light theme, dark theme, high contrast theme

But why remove from current themes?

  1. They are not contrast and hard to notice (as for me)

  2. Other themes like Atom Light doesn't define this color replaces

  3. Default vscode colors are pretty good and contrast

ColCh commented 6 years ago

hm... or just make these colors on scrollbar darker?

swashata commented 6 years ago

Can you show me a screenshot of what you are referring to?

ColCh commented 6 years ago

Sure. Please notice gutters at the right side, on scrollbar

standart theme

image

ayu this : https://github.com/teabyii/vscode-ayu

image

and and bui-ayu (current project)

image

Gutters on scrollbar are hard to notice using bui-ayu, or it's just for me?

swashata commented 6 years ago

You are right. It looks like I have the same color for gutter and the scrollbar/ruler. The color for the ruler shouldn't be transparent.

I will change this to have solid color instead.

ColCh commented 6 years ago

Sounds good. Any preview?

swashata commented 6 years ago

How is this?

screen shot 2018-06-29 at 8 32 39 pm
swashata commented 6 years ago

I have published 1.3.0 with the changes. Feel free to close the issue when you update.

ColCh commented 6 years ago

Thank you! Looks contrast now

image