search

swayok / alternative-laravel-cache

Replacements for Laravel's redis and file cache stores that properly implement tagging idea
MIT License
169 stars 26 forks source link

Stop connecting to CacheStore before it's required to do an action #48

Closed genesiscz closed 1 year ago

genesiscz commented 1 year ago

Fixes https://github.com/swayok/alternative-laravel-cache/issues/47

genesiscz commented 1 year ago

Fixed by https://github.com/swayok/alternative-laravel-cache/commit/9052a1fe6fac43683d105cb03b26c4ec11e6ace8

swayok commented 1 year ago

It is a very bad idea to use app() outside of your project's code (and even there you should avoid it as much as possible). In packages it should not be used actually. Yeah, I used app() here a long time ago, before I learned that it was a bad idea =) Now it also was fixed.

genesiscz commented 1 year ago

I know, but since I didn't run the tests and CI doesn'T have it, I didn't want to risk too much here haha