search

swayok / alternative-laravel-cache

Replacements for Laravel's redis and file cache stores that properly implement tagging idea
MIT License
169 stars 26 forks source link

Laravel 5.8 support #8

Closed davidteal closed 5 years ago

davidteal commented 5 years ago

Hi there.

Thanks for this library, it does exactly how I expected the default functionality to work. I'm having some issues with Laravel 5.8 though, as the cache TTL has changed from minutes to seconds.

See https://laravel.com/docs/5.8/releases#laravel-5.8 under PSR-16 Cache Compliance.

Are there any plans for an update?

Thanks.

swayok commented 5 years ago

Hi. I'm planning to deliver an update this week. I've just started a new project with Laravel 5.8 and probably will face this issue soon.

davidteal commented 5 years ago

Sorry to push but do you have any update? It's currently throwing the error below:

Declaration of AlternativeLaravelCache\Core\AlternativeTaggedCache::putMany(array $values, $minutes) should be compatible with Illuminate\Cache\TaggedCache::putMany

swayok commented 5 years ago

@davidteal This is just a coincidence but I've finished update for Laravel 5.8 several minutes ago =) Also I've fixed that incompatibility in putMany you mentioned. Unfortunately I cannot test it right now because I'm on a starting stage of my new project.

davidteal commented 5 years ago

@swayok Great stuff. I'll update and will post here if I spot any issues.

Thanks.

gmoigneu commented 5 years ago

I can confirm this is working as expected on 5.8.16 Thanks!

swayok commented 5 years ago

@gmoigneu Thank you for confirmation. Then I'm closing the issue.