swaywm / sway

i3-compatible Wayland compositor
https://swaywm.org
MIT License
14.3k stars 1.09k forks source link

KDE's SNI implementation is noncompliant #1372

Closed uberbrodt closed 5 years ago

uberbrodt commented 6 years ago

Hi, I understand that SNI support is enabled in 0.14, but I can't seem to get it to work. I've tried a couple of programs that I know have indicators (transmission-qt, kmix) and neither show up.

sway version (2017-08-09, branch "")

uberbrodt commented 6 years ago

sway.log

ddevault commented 6 years ago

Do those actually support SNI? Try konversation.

uberbrodt commented 6 years ago

Tried Konversation and still no status indicator. Double checked that it was enabled in the app settings.

On Tue, Sep 26, 2017 at 11:46:32AM +0000, Drew DeVault wrote:

Do those actually support SNI? Try konversation.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/SirCmpwn/sway/issues/1372#issuecomment-332173223

ddevault commented 6 years ago

09/25/17 22:05:21 - [main.c:52] [wlc] unable to lock lockfile /run/user/1000/wayland-0.lock, maybe another compositor is running

Are you running another compositor?

uberbrodt commented 6 years ago

Hangon, that maybe a bad log. I started sway a couple of times inside another sway session while trying to get debug logging going.

sway.log

ddevault commented 6 years ago

I'm not sure how the Fedora package works. Can you try building Sway from source and see if you can reproduce the issue? Post the cmake output as well.

uberbrodt commented 6 years ago

Cool. Probably won't get to it until tomorrow at the earliest. I'm going to follow the directions from the README, let me know if I need to do something different with it.

On Tue, Sep 26, 2017 at 02:11:03PM +0000, Drew DeVault wrote:

I'm not sure how the Fedora package works. Can you try building Sway from source and see if you can reproduce the issue? Post the cmake output as well.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/SirCmpwn/sway/issues/1372#issuecomment-332210801

nemanjan00 commented 6 years ago

Any progress?

4e554c4c commented 6 years ago

There isn't enough information to reproduce, so no. However if you've experiencing the problem then maybe you could help out.

nemanjan00 commented 6 years ago

Turns out tray is disabled by default in konversation on Arch... :) Works for me

uberbrodt commented 6 years ago

Sorry, been busy with moving to a new place...I'll see if I can build it and test tonight.

On Oct 12, 2017 02:32, "Nemanja Nedeljković" notifications@github.com wrote:

Turns out tray is disabled by default in konversation on Arch... :) Works for me

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swaywm/sway/issues/1372#issuecomment-336045443, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7towNyvILaWuUhVdFQtYdjwvj5Ze25ks5srcB8gaJpZM4Pjnih .

cjacker commented 6 years ago

SNI support requires a session bus setup before starting sway, if launch sway from TTY, run 'dbus-launch sway', tray should work properly.

4e554c4c commented 6 years ago

@gnidorah Please attatch a debug log of swaybar. This can be done by killing swaybar after starting sway, and running swaybar -d --bar_id bar-0 2> swaybar.log

ghost commented 6 years ago

@4e554c4c Is this a culprit?

10/20/17 21:30:58 - [sni_watcher.c:153] RegisterStatusNotifierItem called with "/org/ayatana/NotificationItem/example_simple_client"

10/20/17 21:30:58 - [sni_watcher.c:157] This item is not valid, we cannot keep track of it.
4e554c4c commented 6 years ago

Yeah, that's it. The problem is that the client is trying to register by object path, which is a "hidden feature" of KDE's SNI implimentation. It's not yet supported because it'd require some deviation from the SNI protocol to make, but it's planned for the future.

4e554c4c commented 6 years ago

We follow the specification plus all the deviations from it that I could find in kde software, eg using org.kde.*, registering by unique name, etc. I'll try to add support for these too, it's just difficult to imagine all the different ways people could impliment the specification.

4e554c4c commented 6 years ago

Ok, support is in the works. @gnidorah if you could link me to your example libappindicator client it'd help a lot.

ghost commented 6 years ago

@4e554c4c Here it is https://askubuntu.com/questions/42211/how-to-create-unity-indicators/234204#234204 and here are build instructions on the top of file https://github.com/dorkbox/SystemTray/blob/master/test/example.c It worked for me under i3 and plasma5. 'go-jump' icon should be in theme.

uberbrodt commented 6 years ago

Sorry for being so late to follow up...I was able to build and test the HEAD revision today and I can confirm that the Konversation icon shows up, however I'm unable to make it respond to actions with either right or left mouse button clicks.

ghost commented 6 years ago

Here to note that KDE SNI works great for me, minor issue is that the right click menu shows in the top right corner, while the bar in my config is at bottom.

4e554c4c commented 6 years ago

Nice catch, I'll fix that.

4e554c4c commented 6 years ago

Should be fixed with #1431

ghost commented 6 years ago

@4e554c4c Indeed it fixes, thank you!

ghost commented 6 years ago

@4e554c4c Another little issue is when I click on ksni4 menu entry under i3, menu auto closes as I expect, but under sway it stay open until I click tray icon again.

ghost commented 6 years ago

@4e554c4c Icon updating doesn't happen on external HDMI monitor but happens on internal eDP with default config. Is this a problem with tray or with something else? Thanks

4e554c4c commented 6 years ago

Not sure, it's probably us though. I'm working on the menu right now but I'll check that out.

r3k2 commented 6 years ago

Hello I tested this with konversation and icon shows but when I click on it no menu, also Idk how to make konversation window come out.. such is why I was looking for the menu :) since click will not pop it up.

4e554c4c commented 6 years ago

@ReK2Fernandez This entire system is being reworked. Please test again once #1431 is merged.

r3k2 commented 6 years ago

Hey thanks for responding... hmm and when is this happening? can I compile it myself ? whats the branch name so I can pull it?

4e554c4c commented 6 years ago

The branch is sni_sucks on https://github.com/4e554c4c/sway. You can compile it and test, but as I said it's still being reworked.

r3k2 commented 6 years ago

lol :) ok I may, as a work around I am running keybase and enpass on their own workspaces .. but that "alsosucks" :)