Unnecessarily nesting tabs when opening programs

[ChrisLane]

Sway Version:

• sway version 1.5-40bdd0ee (Jan 4 2021, branch 'master')

Description:

• When a workspace is set to layout tabbed, I expect programs opened in that workspace to be tabs at the same level.
• Current behaviour seems to make already opened programs in the workspace gain one level of nesting in tabs.

Example:

• Navigate to empty tabbed workspace
• Open Quassel Client
• Open Telegram Desktop
• Open Discord
• 

Additional Info:

• This only seems to happen when opening programs that have some sort of splash screen, loader or updater window (Discord).
• This does not occur when moving programs to the workspace from a different workspace once the splash screen has gone.
• The same cannot be reproduced with other programs that do not have a splash screen such as Firefox and KTouch.
• The same can be reproduced with other programs that do have splash screens such as Jetbrains IDEs.
• This is a behaviour that's appeared within the last few weeks.

[rpigott]

This is a behavior that's appeared within the last few weeks.

Probably #5756

I tried opening discord on an empty workspace with layout tabbed set, but it seems to work fine? I installed Telegram as well and tried opening them both at once but they tab as expected. Can you describe the expected/actual behavior? Could you give the expected/actual workspace representation as reported by swaymsg -t get_workspaces? Are you using workspace_layout in your config or setting the workspace layout by focusing the workspace and running the layout tabbed command?

[ChrisLane]

Could you give the expected/actual workspace representation as reported by swaymsg -t get_workspaces? Workspace output for most basic case (two programs):

Workspace  (off-screen)
Output: HDMI-A-1
Layout: splith
Representation: H[T[T[telegramdesktop] discord]]

I expect the representation to be H[T[telegramdesktop discord]] Are you using workspace_layout in your config or setting the workspace layout by focusing the workspace and running the layout tabbed command?

I'm not using either, I set the tabbed layout for a particular workspace in the config for_window [workspace=] layout tabbed Minimal config I used to reproduce this: https://gist.github.com/ChrisLane/0c949fa762a46720404f6d2643ec177d

[rpigott]

for_window [workspace=] layout tabbed

Ooh, I bet this is why. I don't think we are careful enough in view_map to avoid applying criteria where they don't apply w/ regard to "wants_floating" windows, which would explain why it only happens to "splash screen" clients. I previously didn't know of any bugs it caused so left it alone.

quick steps to reproduce:

1. for_window [workspace=test] layout tabbed
2. open a window on workspace test
3. open a "splash window" on workspace test
4. An additional T split appears in the tiling layer

Better description/debug log later.

[ChrisLane]

@RPigott does this still need an improved description/log or are these comments enough?

[rpigott]

I think these comments are probably enough. A succinct and reliable "steps to reproduce" is usually the most important, and it looks like we've got that. I was just busy at the time and never ended up looking into it further.