swaywm / sway

i3-compatible Wayland compositor
https://swaywm.org
MIT License
14.64k stars 1.11k forks source link

mako notifications stay "burnt in" until screen/region updates otherwise #6914

Closed HarHarLinks closed 9 months ago

HarHarLinks commented 2 years ago

Please fill out the following:

Here is a video of the test case for x in 1 2 3 4 5; do notify-send "test" "message $x"; done:

https://user-images.githubusercontent.com/2803622/158804837-4b88b127-bdda-489a-9543-da793e0e292e.mp4

As you can see, clicking to dismiss a notification makes the others move down, yet they also stay burnt in at their old position. It looks particularly weird if notifications have different heights.

Any update to the screen area will "flush" the lingering notification, that includes switching to (from?) the window behind it. Thus the issue mainly appears when there is no window open on the monitor, e.g. on boot or with a multi monitor setup. The interaction with the mouse cursor wiping the notifications away, while illustrating my point about updating the screen area, actually appears only during recording with wf-recorder - I can normally only get windows to clear them.

Per the original issue, emersion said to try sway -Ddamage=rerender which did help work around the issue.

My platform is arch's core/linux kernel (currently 5.16.16), mako 1.6-3, sway 1.7-2, wlroots 0.15.1-3, gdm 41.3-2.

Nefsen402 commented 2 years ago

Does #6844 help?

HarHarLinks commented 2 years ago

what would testing it entail? clone master, merge PR, build manually? do I need a git version of wlroots?

Nefsen402 commented 2 years ago

Yeah, you need wlroots from git. You can also just pull in the source branch of the PR directly for now, I rebased recently so there shouldn't be conflicts with git wlroots. To test, just run mako and see if the "burn in" remains.

johannlejeune commented 2 years ago

I just came across this issue and I'm experiencing something similar, although not exactly the same behavior. On my side, when I receive multiple notifications at once, some notifications start to flicker until I move my cursor back into the screen (when the notifications appear while my cursor is on the screen, I need to move it out of the screen and back in). I've had this issue for a very long time (maybe more than a year), I just didn't take the time to report it :see_no_evil:

6844 seems to fix the issue, I'm gonna run this fork for now :shrug:

Don't know if it's related, if it's not, I'll create a new issue :+1:

https://user-images.githubusercontent.com/2933420/170819652-c4b09b1a-8017-418d-bf27-e2c6ad1f6bc5.mp4

HarHarLinks commented 2 years ago

Don't know if it's related, if it's not, I'll create a new issue

Yes, it looks like in your video for me too sometimes. I think using a screen recorder as I did changes the effect slightly, you seem to have used an external camera.

vyivel commented 9 months ago

Closed by https://github.com/swaywm/sway/pull/6844.