search

swaywm / wlroots

A modular Wayland compositor library
https://gitlab.freedesktop.org/wlroots/wlroots/
MIT License
2.15k stars 343 forks source link

Layer shell popup positioning #1733

Open wmww opened 5 years ago

wmww commented 5 years ago

Currently layer shell popups can go off the edge of the screen when the positioner rules should prevent that. XDG toplevel popups work correctly.

wlroots has migrated to gitlab.freedesktop.org. This issue has been moved to:

https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/1733

wmww commented 5 years ago

Her are some screenshots from GTK layer shell demo

Rootston with layer (incorrect): wlroots

Rootston with XDG toplevel (correct): wlroots_no_layer

Mir's layer shell branch (correct): mir

ghost commented 5 years ago

Shouldn't it be a compositor's job to move popups? (In sway, popup_unconstrain() does that for XDG popups)

emersion commented 5 years ago

wlroots provides helpers for this.

ammen99 commented 5 years ago

Is this issue about popups going off the screen? In Wayfire, layer shell popups are properly constrained, so this is a Sway bug.