search

swb-ief / etl-pipeline

The Covid Lens
1 stars 10 forks source link

cleanup requirements.txt #100

Closed Nozziel closed 3 years ago

Nozziel commented 3 years ago

Dropped pipfile and pipfile.lock Unneeded complexity for this volenteer project

closes #91

Nozziel commented 3 years ago

@talkgarima

As I understand these files are very useful for identifying the packages that are required to install for the project that is the dependencies. These are very useful when either somebody new joins in or there is significant changes been made. Is there any benefit in deleting the files?

Yes they are not true dependances... non of the code we have written (phase I & II) requires the ones I've deleted. Some might be required indirect by the packages that we do require but it's bad practice to include them both, for this leads to versioning issues when only the primary package version was updated. The packages themselves will upon install, also install those that they require with the proper versions.

So good practice is only to include those that the code cannot run without, and that are directly referenced trough import calls.

I think most of these packages where from the earlier versions or from experiments, or from someone's personal environment and a careless pip freeze | requirements.txt adding a bit too much to it.