search

swc-project / swc-node

Faster ts-node without typecheck
MIT License
1.72k stars 71 forks source link

fix(register): align externalHelpers with tsconfig.importHelpers #686

Closed Brooooooklyn closed 1 year ago

Brooooooklyn commented 1 year ago

@stefee Do you think this behavior is acceptable?

stefee commented 1 year ago

Yep, thanks!

stefee commented 1 year ago

Hello again @Brooooooklyn - just wanted to update you on our issue. We've found that switching to use @swc/jest package directly instead of @swc-node/jest has resolved all of our sourcemap-related problems which were causing test coverage to break. It also seems that the @swc/jest package works without needing any additional configuration. Is there a need for this package going forward?

Brooooooklyn commented 1 year ago

@stefee thanks for the feedback, this project aims to provide zero config experience by automatically reading tsconfig.json. But it seems the upstream SWC iteration breaks that, and I'll fix it asap.

stefee commented 1 year ago

I've opened an issue with a repro - hopefully this helps to get to the bottom of it! https://github.com/swc-project/swc-node/issues/691