search

swc-project / swc

Rust-based platform for the Web
https://swc.rs
Apache License 2.0
31.21k stars 1.23k forks source link

`sourceMaps: false` strill generates source maps #296

Closed dy closed 5 years ago

dy commented 5 years ago 
config.sourceMaps=false
swc.transformSync('code', config) // {code, map}

Is that planned behavior?

(Completely off-topic. Do you mind registering swc-project.github.io in brave rewards - I've sent you a tip there. That would facilitate donations - significantly. @kdy1 )

kdy1 commented 5 years ago

I think you are using old version of swc. swc packaged is renamed to @swc/core. Currently there's a test for it. (https://github.com/swc-project/node-swc/blob/9047e3c08714097eef1a8400587e0867e8ee17e3/__tests__/module_test.js)

dy commented 5 years ago

Hm, there's not test with sourceMap: false flag like that from what I see:

 const out = swc.transformSync('import foo from "foo"', {
        module: {
            type: "commonjs"
        },
        sourceMap: false
    });

I use the latest 1.0.30

kdy1 commented 5 years ago

I fixed it and added a test for sourceMaps: false.

kdy1 commented 5 years ago

Also I tried to set braverewards up, but it only says I need to verify my identity fully on uphold.com

dy commented 5 years ago

@kdy1 yes, you have to create uphold.com cryptowallet for donations - they use that as default financial backpoint. That's just a free wallet service - you can transfer coins then anywhere you want.

swc-bot commented 2 years ago

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.