swc-project / swc

Rust-based platform for the Web
https://swc.rs
Apache License 2.0
31.29k stars 1.23k forks source link

fix: correct option types of wasm-typescript functions #9662

Closed bennypowers closed 1 month ago

bennypowers commented 1 month ago

Description:

The types for the wasm-typescript functions are incorrect due to a typo.

Without this fix:

Property 'TransformConfig' is missing in type '{ module: true; filename: any; sourceMap:   • 
 true; mode: "transform"; transform: { verbatimModuleSyntax: boolean; nativeClassProperties:       
 boolean; importNotUsedAsValues: string; importExportAssignConfig: string; }; }' but required in   
 type 'Options'. [2345]  
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: a59e3543509673de64d929bcef305e5bbe044f4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant commented 1 month ago

CLA assistant check)
All committers have signed the CLA.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #9662 will degrade performances by 4.71%

Comparing bennypowers:patch-1 (a59e354) with main (32116a0)

Summary

❌ 1 regressions ✅ 193 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bennypowers:patch-1 Change
es/full/bugs-1 524.8 µs 550.8 µs -4.71%