swc-project / swc

Rust-based platform for the Web
https://swc.rs
Apache License 2.0
31.29k stars 1.23k forks source link

fix(bindings/node): Add `VisitTsPropertySignature` #9670

Closed jzhan-canva closed 1 month ago

jzhan-canva commented 1 month ago

Description:

As per PR #8955

TsPropertySignature can not have params, type params, or an initializer.

This PR clean up these fields from ts definition and visitor

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: c294d798c2e89a0f9820e35e499ea5fb847b3b11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #9670 will degrade performances by 4.12%

Comparing jzhan-canva:jzhan-fix-visitTsPropertySignature (c294d79) with main (8f45eaf)

Summary

❌ 2 regressions ✅ 192 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jzhan-canva:jzhan-fix-visitTsPropertySignature Change
es/full/bugs-1 518.8 µs 541.1 µs -4.12%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.63%