swc-project / swc

Rust-based platform for the Web
https://swc.rs
Apache License 2.0
31.29k stars 1.23k forks source link

perf(es/lints): Disable lints by default #9689

Closed kdy1 closed 3 weeks ago

kdy1 commented 3 weeks ago

Description:

This is a footgun for users of swc crate. So I changed the default value of jsc.experimental.disableAllLints to true.

Related issue (if exists):

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 6b71522df20392f82e8ae5953fc0ad9026d0f4aa

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #9689 will degrade performances by 4.14%

Comparing kdy1:disable-lints-by-default (6b71522) with main (3597b0f)

Summary

⚡ 23 improvements ❌ 3 regressions ✅ 168 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:disable-lints-by-default Change
es/full/bugs-1 510.9 µs 474.2 µs +7.74%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=false 1.2 ms 1.1 ms +8.38%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=false/reactDev=true 1.4 ms 1.3 ms +5.41%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=false 1.5 ms 1.4 ms +7.03%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true 1.7 ms 1.6 ms +3.7%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false 81.4 ms 76.8 ms +6.03%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true 81 ms 76.8 ms +5.37%
es/oxc/benches/assets/parser.ts/sourceMap=true/reactDev=true 110.3 ms 106.3 ms +3.69%
es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=false 13.3 ms 12.6 ms +5.72%
es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=true 13.3 ms 12.6 ms +5.64%
es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=false 17.8 ms 17.1 ms +4.02%
es/oxc/benches/assets/renderer.ts/sourceMap=true/reactDev=true 17.6 ms 17 ms +3.71%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=false 7.2 ms 6.9 ms +4.82%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=true 8.1 ms 7.8 ms +4.11%
es/full/base/fixer 297.4 µs 117.4 µs ×2.5
es/full/all/es2015 204.2 ms 192.2 ms +6.29%
es/full/all/es2016 202.6 ms 190.5 ms +6.39%
es/full/all/es2017 202 ms 189.9 ms +6.37%
es/full/all/es2018 200.4 ms 188.2 ms +6.46%
es/full/all/es2019 199.4 ms 187.4 ms +6.41%
... ... ... ... ...


:information_source: Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.