search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

Images links broken in novice shell lessons #351

Closed lexnederbragt closed 10 years ago

lexnederbragt commented 10 years ago

https://github.com/swcarpentry/bc/blob/master/novice/shell/01-filedir.md has images that don't appear

rgaiacs commented 10 years ago

@lexnederbragt Thanks to report this. Can you check if the info below is correct?

Summary

When using GitHub preview for Markdown files some images don't appear. E.g. https://github.com/swcarpentry/bc/blob/master/novice/shell/01-filedir.md

Steps to reproduce

  1. Open https://github.com/swcarpentry/bc/blob/master/novice/shell/01-filedir.md#alphabet-soup

Actual results

No images can be found. There is links replacing the images, e.g. "The Filesystem".

Expected results

Found images in the page.

Possible resolution

The lessons in our site, GitHub Pages and my local build of master look fine.

The images are SVG and look like that GitHub preview not support this type of file.

lexnederbragt commented 10 years ago

Hi,

All below is correct, and it looks like this is the cause

The images are SVG and look like that GitHub preview not support this type of file.

Thanks,

Lex

On 1 Mar 2014, at 21:50, r-gaia-cs wrote:

@lexnederbragt Thanks to report this. Can you check if the info below is correct?

Summary

When using GitHub preview for Markdown files some images don't appear. E.g. https://github.com/swcarpentry/bc/blob/master/novice/shell/01-filedir.md

Steps to reproduce

Open https://github.com/swcarpentry/bc/blob/master/novice/shell/01-filedir.md#alphabet-soup Actual results

No images can be found. There is links replacing the images, e.g. "The Filesystem".

Expected results

Found images in the page.

Possible resolution

The lessons in our site, GitHub Pages and my local build of master look fine.

The images are SVG and look like that GitHub preview not support this type of file.

— Reply to this email directly or view it on GitHub.

Lex Nederbragt Norwegian High-Throughput Sequencing Centre (NSC) Centre for Ecological and Evolutionary Synthesis (CEES) Dept. of Biosciences, University of Oslo P.O. Box 1066 Blindern 0316 Oslo, Norway Ph. +47 22844132 +47 48028722 Fax. +47 22854001 Email lex.nederbragt@ibv.uio.no http://www.sequencing.uio.no http://flavors.me/flxlex http://orcid.org/0000-0001-5539-0999

rgaiacs commented 10 years ago

@lexnederbragt Thanks. I'm closing this since it's a GitHub issue.