swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Added ./index.html as dependency for INDEX #523

Closed apawlik closed 10 years ago

apawlik commented 10 years ago

Not quite sure if actually not fixing something that ain't broken but when preparing a boocamp page, I often change 'index.htm'. In order to see if it's OK, I run 'make site' but since ./index.html is not a dependency for 'site' (in Makefile in gh-pages) nothing happens. In the 'master' branch such dependency exists. But the guidelines for creating new bootcamp repositories specify that instructors copy the contents of 'gh-pages'. So I guess it's the Makefile in gh-pages that should include the dependency too?

wking commented 10 years ago

On Fri, May 30, 2014 at 09:04:57AM -0700, Aleksandra Pawlik wrote:

In the 'master' branch such dependency exists.

We can also consider merging master into gh-pages and releasing v2014.06 in two days ;).

apawlik commented 10 years ago

Thanks - I knew I was fixing something that wasn't broken :-)

wking commented 10 years ago

On Fri, May 30, 2014 at 09:37:48AM -0700, Aleksandra Pawlik wrote:

Thanks - I knew I was fixing something that wasn't broken :-)

It's broken ;). I'm just not clear enough on our release process to know if the best fix is a point release (like your patch) or a feature-release (like merging master).

gvwilson commented 10 years ago

+1 to merging master into gh-pages to create v2014.06 on Sunday - Trevor, would you like to do the honors?

wking commented 10 years ago

On Fri, May 30, 2014 at 10:15:26AM -0700, Greg Wilson wrote:

+1 to merging master into gh-pages to create v2014.06 on Sunday - Trevor, would you like to do the honors?

Master is your baby ;). I can write up a release.sh script if you'd like a canned workflow. I certainly don't know what's changed since v2014.04.