search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Workaround for colspan #549

Closed rgaiacs closed 10 years ago

rgaiacs commented 10 years ago

pandoc doesn't play nice with colspan and rowspan. We will avoid using it until pandoc fix this issue.

@acabunoc, could you please take a look in the table at novice/extras/08-numbers.md? I need a CSS fix to my change. Thanks in advance.

abbycabs commented 10 years ago

Hey @r-gaia-cs - did my best, you might be able to come up with a more elegant solution? Hope it helps!

rgaiacs commented 10 years ago

@acabunoc thanks very much.

DON'T MERGE THIS PR YET. I want to wait get answer for jgm/pandoc#1359 and undo d5b2c92 if possible.

rgaiacs commented 10 years ago

Ready to merge after review.

For small screen devices (e.g. mobile phones) the table will be a little ugly.

screen shot 2014-06-06 at 18 59 16

But for large screen devices (e.g. tablets) the table will have the same look and the EPUB version will be OK.

table

gvwilson commented 10 years ago

Mmm... it's still not great. I realize you don't want to hand-edit the HTML, but is there some other hack we can do to insert tables with multi-columns after the automatic translation?

rgaiacs commented 10 years ago

is there some other hack we can do to insert tables with multi-columns after the automatic translation?

Yes. Something like #550.

rgaiacs commented 10 years ago

Merge as part of #435.