Closed keszybz closed 9 years ago
@r-gaia-cs @jiffyclub good to merge?
One thing to think about that doesn't necessarily need to be addressed by this PR: for workshop setup instructions we break things down in detail across different system types and the things to install. For these instructions we're kind of throwing everything together with little organization. I think we might want to revisit this after #759 and organize the site build instructions by system and tool as we do for workshops.
If I'm a R user maybe I don't want to install ipython-notebook. This line should only cover jekyll. The cost of installing a few additional (binary) packages is essentially zero. The time to read the instructions is worth more than the tiny amount of disk space. So I think that the "big hammer" approach of installing everything at once is right in this case.
I strongly disagree. These instructions are specifically about how to build a workshop site. Python and the Notebook are unnecessary for that. Having extra, unrelated installs listed here only confuses things.
@jiffyclub Yes, the README.md
will need to be rewrite after #759. I want to merge it just as a reminder when we going to rewrite README.md
but I'm OK to don't merge it if it is blocking #759. @gvwilson Any comment?
@keszybz Normally I will agree with you in
The cost of installing a few additional (binary) packages is essentially zero. The time to read the instructions is worth more than the tiny amount of disk space. So I think that the "big hammer" approach of installing everything at once is right in this case.
I disagree on this because to preview the lessons the user only need Jekyll. If the user is going to modify the Python lesson he/she will need IPython Notebook but if the user is going to modify the R lesson he/she will need R/RStudio, so why not
$ apt-get install r rstudio jekyll ruby-kramdown ruby-colored make python ipython-notebook unzip pandoc
I will close this for now and work on it after we explode the repo.
@keszybz Thanks for your contribution. We probably will reword
README.md
and include this.