v5 lessons appear under v4 on mobile - Githubissues

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.

Other

299 stars 383 forks source link

v5 lessons appear under v4 on mobile #601

Closed chendaniely closed 9 years ago

chendaniely commented 10 years ago

screenshot_2014-07-18-23-57-22 Does anyone else see this?

I see this on my nexus 7 (grouper) and note2 both running CyanogenMod viewed on Chrome

twitwi commented 10 years ago

Same for me, the list of lessons for v5 appear below the v4 title.

firefox aurora on an android device
also on the desktop (firefox) in the responsive design view (Ctrl+Shift+M)

It is probably an easy fix for someone who manipulate bootstrap daily.

twitwi commented 10 years ago

@gvwilson : I have a fix (bootstrap is actually not difficult), but I could not find the sources for lessons.html. where can I "push" this?

gvwilson commented 10 years ago

The lessons are in the 'bc' repository - we put that stuff into the web site when we build on the server.

twitwi commented 10 years ago

Hi @gvwilson , I meant the "lessons.html" (that is shown there http://software-carpentry.org/lessons.html ), maybe I missed it but I cannot find anything about it in the bc repo.

rgaiacs commented 10 years ago

@twitwi You are looking for site/lessons.html.

twitwi commented 10 years ago

thanks @r-gaia-cs , I forgot about the "site" repository. I'm making a pull request.

twitwi commented 10 years ago

here : https://github.com/swcarpentry/site/pull/553

twitwi commented 10 years ago

I guess this issue can be closed (or moved to the "site" repo).

rgaiacs commented 10 years ago

@twitwi Thanks. We can't move the issue to "site" repository. After we close swcarpentry/site#553 we will close this one.

chendaniely commented 9 years ago

https://github.com/swcarpentry/site/pull/553 is closed. Propose to close this