swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

Missing images at regex lesson #619

Closed rgaiacs closed 9 years ago

rgaiacs commented 10 years ago

All the images at intermediate/regex/04-under-the-hood.md are missing.

$ grep -r png intermediate/regex/04-under-the-hood.md           
'a'](../img/regexp/fsm-single-lower-case-a.png)
'a'](../img/regexp/fsm-one-or-more-a.png)
nothing](../img/regexp/fsm-one-a-or-nothing.png)
'a'](../img/regexp/fsm-zero-or-more-a.png)
'a'](../img/regexp/fsm-simpler-zero-or-more-a.png)
![A more complex FSM](../img/regexp/fsm-complex.png)
$ find . -name '*fsm*'

@gvwilson Could you add it?

gvwilson commented 10 years ago

I haven't created these - someone will need to look at the original (Version 4) material at http://software-carpentry.org/v4/regexp/index.html and re-draw the diagrams in something that isn't PowerPoint.

jdcorless commented 10 years ago

I have 5 of 6 images created in SVG format ready to submit. But I have two questions...

  1. The "simpler zero or more a" case does not appear to be in the V4 material, and I am not sure what it should look like. Here is my re-drawn "zero or more a" case, how to simplify? fsm-zero-or-more-lower-case-a
  2. Better to wait for bc split before submitting PR? Thanks.
gvwilson commented 10 years ago

@ctjacobs are you willing to look at this?

ctjacobs commented 10 years ago

Sure, I'll take a look tonight.

jdcorless commented 10 years ago

@ctjacobs I answered my own questions and submitted a PR. Maybe you could review that? Thanks.