swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

The 'pygments' configuration option has been renamed to 'highlighter' #629

Closed rgaiacs closed 9 years ago

rgaiacs commented 9 years ago

After update my system to

$ ruby --version
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux]
$ jekyll --version
jekyll 2.1.1

I got one warning when trying to build the lessons:

$ git rev-parse HEAD
14db6d4c825679e5709e2f10d58890a6e0955cb5
$ make site
jekyll build -t -d _site
Configuration file: /home/raniere/documents/software_carpentry/bc/_config.yml
       Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null.
            Source: /home/raniere/documents/software_carpentry/bc
       Destination: _site
      Generating... 
                    done.

Fix this warning can break the build process to ours contributors, at our server and at GitHub pages.

gvwilson commented 9 years ago

Does this actually break our build, or just generate a message?

rgaiacs commented 9 years ago

Does this actually break our build, or just generate a message?

It just generate a message. Maybe is safe to remove

pygments        : true

from _config.yml since we don't use Jekyll highlight

{% highlight ruby %}
def what?
  42
end
{% endhighlight %}

neither kramdown highlight

~~~
def what?
  42
  end
~~~
{: .language-ruby}

or

~~~ ruby
def what?
  42
end
~~~