swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

Add portuguese translation of index.html #630

Closed rgaiacs closed 10 years ago

rgaiacs commented 10 years ago

This implement the first suggestion of #602 because index.html uses _includes/setup.html and I didn't find one way to make translations/pt/index.html uses translations/pt/_includes/setup.html or something similar.

Long Description

rgaiacs commented 10 years ago

@gvwilson Any comments?

dpshelio commented 10 years ago

From the Spanish translation team we haven't got that far yet... we have started with the content. Next step is going to work out in the integration with the rest. I was thinking in allow all the languages in the same place, without the instructor having to change anything, just by the browser to choose the language by itself (or a dropdown menu). Of course, that needs a bit of thought to have it all integrated.

As you mentioned in #602 this will fill the root directories with a lot of files. Would the _includes/setup.html problem would be easier to solve if we would have an en translation directory? and then the file loaded would be: translation/??/_includes/setup.html?

rgaiacs commented 10 years ago

From the Spanish translation team we haven't got that far yet...

This PR exists only because of a couple of bootcamps in Brazil and I will hate that anyone have to translate from scratch our index.html and setup.html in the future.

Would the _includes/setup.html problem would be easier to solve if we would have an en translation directory? and then the file loaded would be: translation/??/_includes/setup.html?

The problem is that the include directive of Jekyll/Liquid only work with files at _includes and not with foo/_includes. We could use symbolics links from _includes/setup-XX.html to translation/XX/_includes/setup.html but this will not reduce the number of files at _includes and add the trouble that Git didn't handle symbolics links very well.

gvwilson commented 10 years ago

I suggest closing this one and re-thinking after #759 lands - we will need a strategy for non-English lesson translations in general.

rgaiacs commented 10 years ago

I agree with @gvwilson

I suggest closing this one and re-thinking after #759 lands - we will need a strategy for non-English lesson translations in general.