Adding make lesson - Githubissues

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.

Other

299 stars 383 forks source link

Adding make lesson #635

Closed chwilk closed 9 years ago

chwilk commented 9 years ago

Giant pull request for cohort 09's work on Make lesson

rbeagrie commented 9 years ago

Is this PR ready for review or waiting for more contributions?

gvwilson commented 9 years ago

Waiting on review from me - hope to get to it today or tomorrow.

rgaiacs commented 9 years ago

@chwilk Thanks for this PR and sorry for the delay in review it. Most of my comments are duplicates of the same problem but at different line (I didn't mark intermediate/make/02-patterns.html so you need to check it). Some others comments are:

intermediate/make/00-intro.html
- [ ] "finds himiself saying" -> ""finds himself saying"
- [ ] ## Before getting started" -> "### Before getting started"
intermediate/make/01-basics.html
- [ ] @gvwilson could paper.pdf depends on figure-1.png instead of figure-1.svg?
- [ ] latexmk will not work at Windows by default since it request Perl.

twitwi commented 9 years ago

I could not review everything but I have a side note: usually, we should avoid raster formats (like PNG) in PDF. I usually convert my SVG files to PDF and include them directly in latex. And, I also think that the paper.pdf should depend on the figure-1.pdf (or .png).

I actually have a makefile (and .gitignore) that I reuse for all my papers. It might be too complex for a lesson, but I thought it could be good to share: https://github.com/twitwi/ResearchTipsAndTricks/tree/master/PaperMakefile

rgaiacs commented 9 years ago

+1 for "avoid raster formats (like PNG) in PDF." Since SVG don't play nice with LaTeX and EPS is old I'm +1 to use PDF for the figures.

gvwilson commented 9 years ago

We use SVG rather than PNG (because SVG editors are more commonplace, and browsers can render SVG inline), then convert to PDF during production when needed.