swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

At book.html some HTML attribute id are duplicated #644

Closed rgaiacs closed 9 years ago

rgaiacs commented 9 years ago

From MDN

This attribute, id, defines a unique identifier (ID) which must be unique in the whole document. Its purpose is to identify the element when linking (using a fragment identifier), scripting, or styling (with CSS).

but at book.html we can find duplicates

$ make book
....
$ grep 'id="objectives"' _site/book.html | head -n 2
  <h4 id="objectives">Objectives</h4>
<h4 id="objectives">Objectives</h4>
$ grep 'id="objectives"' _site/book.html | wc -l
17

This duplicated id attributes happens due our IPython Notebook lessons since when we convert it to Markdown instead of

#### Objectives

it use

<h4 id="objectives">Objectives</h4>

as you can check here.