search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Lesson improvement: code review #667

Closed luizirber closed 9 years ago

luizirber commented 9 years ago

This is an assignment for Instructor Training round 10, joint work by @luizirber and @rosariorobinson

We added a few screenshots and explained how to start a PR on GitHub and add comments for code review purposes.

(A/C @gvwilson )

luizirber commented 9 years ago

Are the images too big? Some parts (like headers) can be cropped, but they also give more context about the GitHub UI.

chendaniely commented 9 years ago

i like the context the images provide. Very useful for the new comers, like me.

If anything more context is needed, like including the fact you are in the pull request tab on the right.

rgaiacs commented 9 years ago

This looks good to me.