search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

removed require() as means to load library #669

Closed chendaniely closed 9 years ago

chendaniely commented 9 years ago

same PR as #668, but done correctly.

This is a PR that addresses #664

I did a grep -r require( ./ and grep -r require ./ grep to search for other instances of require, only found these cases where require was used to talk about importing libraries.

chendaniely commented 9 years ago

@jdblischak can this be merged? I realized I had to do a rebase on the original PR, but this is the same as #668

jdblischak commented 9 years ago

What happened to the YAML header in the Markdown file? It should get transfered from the R Markdown file when it is knit.

chendaniely commented 9 years ago

it's just: layout: lesson root: ../.. right? it's still there.

jdblischak commented 9 years ago

Not that I can see.

https://raw.githubusercontent.com/chendaniely/bc/r-library-require/novice/r/06-best_practices-R.md

If you run knit("06-best-practices.Rmd") it will be transfered.

chendaniely commented 9 years ago

sorry, thought you were referring to the Rmd document, read that wrong.

what's weird is none of my .md documents have the YAML header

jdblischak commented 9 years ago

Currently not all of them properly have the YAML header, but many do, e.g.

https://raw.githubusercontent.com/chendaniely/bc/r-library-require/novice/r/01-starting-with-data.md

But I just realized that you would need to do more than just knit the file to get it to properly render, so don't worry about it.

Thanks for making this update!