search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Add note about SSH_ASKPASS #677

Closed rgaiacs closed 9 years ago

rgaiacs commented 9 years ago

Cover #656.

@wking Could you review this?

wking commented 9 years ago

On Sun, Aug 24, 2014 at 08:28:03AM -0700, r-gaia-cs wrote:

  • Add note about SSH_ASKPASS

It's usually “operating system”, not “operational system”. I also prefer “You may want to add thiss…” to “Maybe you want add this…”.

Why do you have the leading greater-thans (>)? This doesn't seem like a blockquote 1.

rgaiacs commented 9 years ago

It's usually “operating system”, not “operational system”. I also prefer “You may want to add thiss…” to “Maybe you want add this…”.

Fixed.

Why do you have the leading greater-thans (>)? This doesn't seem like a blockquote 1.

Because we use it to create a text box [2].

[2] https://github.com/swcarpentry/bc/blame/master/novice/shell/01-filedir.md#L82

wking commented 9 years ago

On Tue, Aug 26, 2014 at 03:10:08PM -0700, r-gaia-cs wrote:

Why do you have the leading greater-thans (>)? This doesn't seem like a blockquote 1.

1: http://daringfireball.net/projects/markdown/syntax#blockquote

Because we use it to create a text box 2.

2 https://github.com/swcarpentry/bc/blame/master/novice/shell/01-filedir.md#L82

Ugh. I'd prefer reStructuredText to overloading existing Markdown syntax, but that's probably outside the scope of this PR ;).

It would be nice if we could link from the .bashrc reference to some discussion of that file in the shell lesson. For example, here [1,2](ideally we'd have a local link anchor whenever we introduce a new idea like .bashrc files, so we could have more tightly-targeted links).

rgaiacs commented 9 years ago
  • “an password manager” → “a password manager”.
  • “when requesting your username…” → “when it needs your username…”.
  • maybe “If you want to type your username and password at the terminal, type” → “If you want to type your username and password at the terminal instead of using a password manager, type”.

Fixed.

It would be nice if we could link from the .bashrc reference to some discussion of that file in the shell lesson. For example, here [1,2](ideally we'd have a local link anchor whenever we introduce a new idea like .bashrc files, so we could have more tightly-targeted links).

I agree but I want to leave it to another PR because [1, 2] are at the intermediate lesson and maybe using something like #607.

wking commented 9 years ago

On Wed, Aug 27, 2014 at 04:00:33AM -0700, r-gaia-cs wrote:

It would be nice if we could link from the .bashrc reference to some discussion of that file in the shell lesson…

I agree but I want to leave it to another PR…

In that case, I think we're good to go here :).