search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

added HDF5 lesson to intermediate R curriculum #687

Closed emhart closed 9 years ago

emhart commented 9 years ago

Per Greg's request I've added in the lesson for working with HDF5 in R and an associated data set.

jdblischak commented 9 years ago

Thanks for the PR, @emhart. Could you please send out a message to the r-discuss mailing list to let R instructors know there is a new lesson to review?

emhart commented 9 years ago

Thanks for all the feedback all. I'll take those into consideration and add some more commits. I will also definitely work on a bit about making your own hdf5 files.

As far as using a smaller file @sje30 I take your point. I was hoping to provide learners with a real world file as an example. Perhaps I can start off with writing and reading a file, and then go on to using the larger file.

sje30 commented 9 years ago

Great -- also, chcek out:

https://github.com/sje30/waverepo/blob/master/paper/waverepo_paper.Rnw

if you want a real example of combining hdf5+R+knitr to make a published paper: http://www.gigasciencejournal.com/content/3/1/3

Stephen

On Fri, Sep 05 2014, Edmund Hart wrote:

Thanks for all the feedback all. I'll take those into consideration and add some more commits. I will also definitely work on a bit about making your own hdf5 files.

As far as using a smaller file @sje30 I take your point. I was hoping to provide learners with a real world file as an example. Perhaps I can start off with writing and reading a file, and then go on to using the larger file.

Reply to this email directly or view it on GitHub: https://github.com/swcarpentry/bc/pull/687#issuecomment-54679032

Sent with my mu4e

jdblischak commented 9 years ago

Thanks for the reviews, @chendaniely and @sje30.

@emhart, this PR received good reviews. Do you have time to address their suggestions in the next few days? The haste is due to the imminent breakup of the bc repo (see #759 and Greg's blog post). If not, we can close this issue and you can send a new PR in the future.

emhart commented 9 years ago

I'll send a new PR this weekend @jdblischak will that make it before the breakup?

jdblischak commented 9 years ago

Thanks, @emhart. If you send in the final changes in the next few week you should be fine. You have two choices:

  1. You can continue to update the current PR. If you choose this option, you'll need to undo your last merge commit. Since you are adding a new file, there is no need to update all the other files in the repo in your PR.
  2. Create a new feature branch, cherry-pick your commits, and then send a PR from the new feature branch.

Please let me know if I need to explain more or if you need any help with this.

emhart commented 9 years ago

closing and the reissuing new PR from new fork with updated lessons.