search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Move SSH Key lesson from Git to Extras #707

Closed rgaiacs closed 9 years ago

rgaiacs commented 9 years ago

Related with #691.

jdblischak commented 9 years ago

Other than some rewording of the description of HTTPS v. SSH, I am overall +1 on this PR.

wking commented 9 years ago

On Wed, Sep 10, 2014 at 08:44:52AM -0700, r-gaia-cs wrote:

https://github.com/swcarpentry/bc/pull/707

  • Git's diff shows some trailing whitespace after “granted access.”. We might as well remove that in this commit as well.
  • “HTTPS vs SSH Key” → “HTTPS vs SSH”.
  • “Using SSH Key” → “Using SSH keys”.
  • “following greats how to” → “following the great how-tos” (following Wikipedia's hyphenation 1).
  • “about SSH Key” → “about SSH”

You have a few other tweaks to the copied content. I haven't looked over them all, but you add ‘xclip’ and ‘Shift + Insert’ references which are probably not portable ;). Personally, I use ‘xsel’ and middle-click for that, but I'm sure those aren't portable either ;). For this commit, I'd try to make as few semantic changes to the copied content as possible (but I'm for fixing typos and such like trailing whitespace).

rgaiacs commented 9 years ago

Pull request updated with suggestions.

jdblischak commented 9 years ago

+1 to merge

wking commented 9 years ago

On Fri, Sep 12, 2014 at 07:00:26AM -0700, John Blischak wrote:

+1 to merge

Agreed.

gdevenyi commented 9 years ago

+1 to merge

rgaiacs commented 9 years ago

I'm merging this.