swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

Quick feedback on Git lesson on 'open science' #712

Closed cboettig closed 8 years ago

cboettig commented 10 years ago

Hi SWC,

Was just reading through the Open Science lesson under git and thought I would make a few notes to myself about things that could be improved. I can try and get around to a pull request on this, so this is somewhat of a to-do list of things I might tackle in the pull request. Other suggestions, background or push-back is (of course) welcome! It will help guide me before I make too many foolish edits.

This lesson appears to be about open source licensing and hosting, not about "Open Science" per se. (With the exception of the opening vignette that compares two workflows, highlighting all kinds of issues that will not actually be covered in this lesson.) Perhaps the title could be revised to reflect the focus on software licensing and hosting issues (which fits most naturally under the "git" section anyway). Consider:

This section jumps in a bit too quickly for me. I'd suggest first

It's not entirely clear if this section is talking about distributing code or about more general work. Since we're not covering data repositories, preprint servers, etc in this section, I think it should be made more clear that the focus is on software hosting. I think this section could be much more concise and potentially more prescriptive: "While researchers frequently distribute code and software by hosting it on their own websites (either on a university or private server), hosting on a dedicated code repository has several advantages." and then briefly mention link rot as the main issue, but also versioning and issue/bug tracking tools available on the repositories you list. (see, e.g. JORS code repo requirements)

Conclusions

wking commented 10 years ago

On Fri, Sep 12, 2014 at 10:53:27AM -0700, Carl Boettiger wrote:

  • [ ] "Projects can be hosted on university servers, on personal domains, or on public forges" -> "projects hosted on public repositories are more likely to be still available in the future"

I'd stick to “forges” to avoid confusion between Git repositories (which hold a single project) and hosting sites (e.g. SourceForge, GitHub, ...; which host many projects). The students just made it through their first Git lesson, where we repeatedly use “repository” in the single-project sense.

Other than that, these all sound like great changes to me :).

cboettig commented 10 years ago

@wking Good point, I was just using "repository" in the same sense as JORS or as with data archiving, but I see where that would be confusing given the context of the other lessons. I just don't find the term "Forge" particularly intuitive (Not that the suffixes "Bucket" or "Hub" are much better). Any suggestions?

wking commented 10 years ago

On Fri, Sep 12, 2014 at 11:17:56AM -0700, Carl Boettiger wrote:

I just don't find the term "Forge" particularly intuitive (Not that the suffixes "Bucket" or "Hub" are much better). Any suggestions?

I think “forge” is ok (and Wikipedia at least recognizes it 1), but I agree that it is jargon-y. There's also the more explicit (but less romantic) “hosting site”, although that doesn't imply auxilliary services such as issue tracking. Finally, Wikipedia sometimes uses the unwieldy “collaborative software development management system”. In this case (novice students), it's probably best to bite the bullet and use the wordy form, linking it to Wikipedia's software forge article so the curious can learn the jargon ;).

rgaiacs commented 10 years ago

Carl,

I agree with your suggestions. If you need help using git just ask.

I suggest that you split your suggestions in two or three pull requests to help us review it but won't be a problem if you create only one pull request.