search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

info on how to display the menu bar #783

Closed fmichonneau closed 9 years ago

fmichonneau commented 9 years ago

At our last workshop, some participants were confused by the last sentence of the instructions for the plugin installation: they didn't know what to do after starting the plugin. I added additional information to indicate it was just a check to see that the plugin installed successfully.

Most people were however unable to start the plugin before coming to the workshop, as newer versions of firefox hide by default the menu bar. I added instructions on how to make it appear.

ethanwhite commented 9 years ago

I've definitely encountered this as well. The change looks great. +1

rgaiacs commented 9 years ago

+1 from me.

ethanwhite commented 9 years ago

I'm not sure what the protocol is here for merging since @fmichonneau is both the maintainer and the initiator of this pull request, but with two positive reviews on a minor change I think someone should go ahead and push the green button.

@gvwilson do you have any thoughts on how this sort of situation should generally be handled?

fmichonneau commented 9 years ago

I don't have write access yet, but I otherwise like the +2 "rule" on a minor change.

ethanwhite commented 9 years ago

In that case I'll go ahead and get this in.

@gvwilson - when you get the chance @fmichonneau needs push privileges to fulfil his maintainer responsibilities.

gvwilson commented 9 years ago

I've invited @fmichonneau to the 'Developers' group.

@gvwilson https://github.com/gvwilson - when you get the chance @fmichonneau https://github.com/fmichonneau needs push privileges to fulfil his maintainer responsibilities.