search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 382 forks source link

Fix inconsistencies in string representation in MATLAB lessons #786

Closed shwina closed 9 years ago

shwina commented 9 years ago

This PR fixes the inconsistencies with the way we represent strings in the MATLAB lessons. I changed all strings to use single quotes.

shwina commented 9 years ago

P.S. Can't wait till they invent time travel so that I can go back and change all the embarrassing commit messages I've made.

rgaiacs commented 9 years ago

P.S. Can't wait till they invent time travel so that I can go back and change all the embarrassing commit messages I've made.

You can use

$ git checkout fix-string
$ git rebase -i HEAD~3

Git will open your editor. Replace pick with reword to change the commit message. You can also replace pick with squash to join it with the next commit.

After you close your editor,

$ git push -f origin fix-string

I don't know why you need a379127. If you are going to change your commit messages I would ask to remove this commit.

shwina commented 9 years ago

@r-gaia-cs Thanks, I tried messing about with rebase but I think I made the problem worse :) Not sure what I did to make those previous commits appear there. The files changed looked the same though, is this okay, or is there something I need to fix?

rgaiacs commented 9 years ago

I tried messing about with rebase but I think I made the problem worse :)

No problem. The advantage of Git is that your work is saved. =)

is there something I need to fix?

Yes, we need to fix it. @ashwinsrnth Do you have some time on Thursday or Friday when we can work on this (please email me to avoid spam GitHub)?