search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Mention comments at MATLAB lesson #803

Closed IsaKiko closed 9 years ago

IsaKiko commented 9 years ago

I think we should introduce commenting as early as possible. @ashwinsrnth, should we have the 'publish'-section is this lesson? I would also suggest that we change 'i' to 'idx', since 'i' is the imaginary unit in Matlab.

rgaiacs commented 9 years ago

@IsaKiko Thanks for the contributions. This looks good to me but let @ashwinsrnth review it before merge.

Could you change the title of this PR to something more meaningful? Maybe "Mention comments at MATLAB lesson"?

Please create another pull request for

IsaKiko commented 9 years ago

Cool I didn't know that. Changed it back.

shwina commented 9 years ago

@IsaKiko @r-gaia-cs

Looks good to me.

should we have the 'publish'-section is this lesson?

In #686, we decided against the section on publish, as it was specific to MATLAB. We're hard pressed for time as it is, and a section on publishing might be a better idea in the intermediate materials.

On changing i to idx, I am +1. But I'm almost hoping someone can convince me otherwise :)