search

swcarpentry / DEPRECATED-bc

DEPRECATED: This repository is now frozen - please see individual lesson repositories.
Other
299 stars 383 forks source link

Updated shell script to change $* to $@ and fix quoting errors #871

Closed buske closed 9 years ago

buske commented 9 years ago

The existing lesson ignores quoting and uses $* instead of $@. This causes all example scripts to fail if a file path ever has whitespace in it.

I realize that it adds a bit of complexity to the lesson, but I think that it is worth discussing in light of the likelihood that novices will run into this issue early on.

buske commented 9 years ago

I see on another pull request for shell content that this should perhaps be directed towards this repo instead: https://github.com/wking/swc-modular-shell

Is that correct?

wking commented 9 years ago

On Tue, Nov 18, 2014 at 10:39:32PM -0800, Orion Buske wrote:

I see on another pull request for shell content that this should perhaps be directed towards this repo instead: https://github.com/wking/swc-modular-shell

Is that correct?

Yup.

buske commented 9 years ago

Replaced with wking/swc-modular-shell#19