Closed bshambaugh closed 8 years ago
Raniere,
What do mean by remove fe2dcfc6?
Sent from my iPhone
On Nov 21, 2014, at 7:34 PM, Raniere Silva notifications@github.com wrote:
@bshambaugh Thanks for this.
Comments
Use meaningful names for your branches. E.g. add-file-transfer-lesson instead of bshambaugh. Use meaningful titles for your pull request. E.g "Add file transfer lesson in extras". Provide a description of your changes. E.g. "Create a new lesson in extras about file transfer covering curl." If this is for teaching trainning, please mention it. Avoid changes in different files at the same pull request. At this pull request you change novice/extras/10-file_transfer.md, novice/extras/10-why.md, novice/extras/11-why.md, novice/extras/index.md, novice/shell/02-create.md. The changes at novice/extras/10-file_transfer.md, novice/extras/10-why.md, novice/extras/11-why.md, novice/extras/index.md is totally OK in be at the same pull request since they are related but you could use another pull request for novice/shell/02-create.md. Requests
If you have any question or need help just ask. =)
Migrate the change at novice/shell/02-create.md to https://github.com/wking/swc-modular-shell. Fork https://github.com/wking/swc-modular-shell, clone your fork, create a feature branch, checkout to the new branch, redo the changes, commit, push your changes and finally open a pull request. Change the title of this pull request to something more meaningful about your file transfer lesson. You can do it using the "Edit" button after the title. Add a description for this pull request. Click at the pencil at the top right corner of the first comment. Remove fe2dfc6 from this PR: $ git checkout master $ git checkout -b wip $ git cherry-pick 5ddfa62 $ git cherry-pick 11bcdba $ git cherry-pick d753b22 $ git cherry-pick 7605a92 $ git cherry-pick bbd00de $ git branch -f bshambaugh $ git checkout bshambaugh $ git push -f origin bshambaugh Address others comments and update your patch queue (just create new commits at your bshambaugh branch and push it). — Reply to this email directly or view it on GitHub.
Raniere,
What do you mean by updating the patch queue?
git commit -m "updated patch queue" ?
Sent from my iPhone
On Nov 21, 2014, at 7:34 PM, Raniere Silva notifications@github.com wrote:
@bshambaugh Thanks for this.
Comments
Use meaningful names for your branches. E.g. add-file-transfer-lesson instead of bshambaugh. Use meaningful titles for your pull request. E.g "Add file transfer lesson in extras". Provide a description of your changes. E.g. "Create a new lesson in extras about file transfer covering curl." If this is for teaching trainning, please mention it. Avoid changes in different files at the same pull request. At this pull request you change novice/extras/10-file_transfer.md, novice/extras/10-why.md, novice/extras/11-why.md, novice/extras/index.md, novice/shell/02-create.md. The changes at novice/extras/10-file_transfer.md, novice/extras/10-why.md, novice/extras/11-why.md, novice/extras/index.md is totally OK in be at the same pull request since they are related but you could use another pull request for novice/shell/02-create.md. Requests
If you have any question or need help just ask. =)
Migrate the change at novice/shell/02-create.md to https://github.com/wking/swc-modular-shell. Fork https://github.com/wking/swc-modular-shell, clone your fork, create a feature branch, checkout to the new branch, redo the changes, commit, push your changes and finally open a pull request. Change the title of this pull request to something more meaningful about your file transfer lesson. You can do it using the "Edit" button after the title. Add a description for this pull request. Click at the pencil at the top right corner of the first comment. Remove fe2dfc6 from this PR: $ git checkout master $ git checkout -b wip $ git cherry-pick 5ddfa62 $ git cherry-pick 11bcdba $ git cherry-pick d753b22 $ git cherry-pick 7605a92 $ git cherry-pick bbd00de $ git branch -f bshambaugh $ git checkout bshambaugh $ git push -f origin bshambaugh Address others comments and update your patch queue (just create new commits at your bshambaugh branch and push it). — Reply to this email directly or view it on GitHub.
What do mean by remove fe2dcfc6?
Discard the commit named fe2dcfc6.
What do you mean by updating the patch queue?
Patch is another name for commit. By updating the patch queue I mean
$ git push origin bshambaugh
Hi @bshambaugh, could you remember what is the status of this lesson?
Hmm... I think https://github.com/bshambaugh/bc/commit/8ecdfc4bb6cc231b1a3ba256192e4bb43863cf0a was my most recent attempt at making the changes you suggested.
I do believe that this repository was closed for migration?
I do believe that this repository was closed for migration?
I don't remember if the extras
directory was close. @gvwilson can you clear for us the status of extras
?
@bshambaugh I made some comments but didn't mark all issues when they are repeated.
@raniere, @gvwilson I completed my lesson. Where should I put it?
Hi Brent, Sorry to be slow replying on this - please send me the text and I'll figure out which of our repos it should go in. Thanks much, Greg
Covered in https://github.com/swcarpentry/shell-extras
@bshambaugh Thanks for this.
Comments
add-file-transfer-lesson
instead ofbshambaugh
.extras
about file transfer coveringcurl
." If this is for teaching trainning, please mention it.novice/extras/10-file_transfer.md
,novice/extras/10-why.md
,novice/extras/11-why.md
,novice/extras/index.md
,novice/shell/02-create.md
. The changes atnovice/extras/10-file_transfer.md
,novice/extras/10-why.md
,novice/extras/11-why.md
,novice/extras/index.md
is totally OK in be at the same pull request since they are related but you could use another pull request fornovice/shell/02-create.md
.Requests
If you have any question or need help just ask. =)
novice/shell/02-create.md
to https://github.com/wking/swc-modular-shell. Fork https://github.com/wking/swc-modular-shell, clone your fork, create a feature branch, checkout to the new branch, redo the changes, commit, push your changes and finally open a pull request.bshambaugh
branch and push it).