Closed dlebauer closed 9 years ago
On a few workshop websites, I noticed that the links at the bottom of the page do not go anywhere ... Email, Twitter, rss
Good catch - can you give a pointer so I can diagnose?
In addition, the "fork me" banner in the upper right goes to the swcarpentry master rather than to the fork. This may be the desired behavior in ths case of the SWC websites, but this is not the expected behavior based on the definition of 'Fork me'.
Can you please submit a PR to lesson-template so that the 'fork me' banner appears on lessons, and points to the right place? Or file an issue in lesson-template so that someone else can look at it?
I also noticed the fact that that at the end of the README instructions there are two links to required steps that could be easily overlooked:
https://github.com/swcarpentry/workshop-template/blob/gh-pages/CUSTOMIZATION.md
https://github.com/swcarpentry/workshop-template/blob/gh-pages/DESIGN.md
- this one has a link to a non-existent 'variables' section https://github.com/swcarpentry/workshop-template/blob/gh-pages/DESIGN.md#variables
Good catch - can you please review https://github.com/swcarpentry/workshop-template/pull/81 (which fixes this)?
Dr. Greg Wilson | gvwilson@software-carpentry.org Software Carpentry | http://software-carpentry.org
Can you please submit a PR to lesson-template so that the 'fork me' banner appears on lessons, and points to the right place? Or file an issue in lesson-template so that someone else can look at it?
I would be happy to, but I was referring to the workshop-template websites (e.g. the two listed above), though both of those seem to have been forked from this repository.
can you please review https://github.com/swcarpentry/workshop-template/pull/81
done (swcarpentry/workshop-template#81)
workshop-template links Completed by swcarpentry/workshop-templatte#92
On a few workshop websites, I noticed that the links at the bottom of the page do not go anywhere ... Email, Twitter, rss, e.g.:
In addition, the "fork me" banner in the upper right goes to the swcarpentry master rather than to the fork. This may be the desired behavior in ths case of the SWC websites, but this is not the expected behavior based on the definition of 'Fork me'.
I also noticed the fact that that at the end of the README instructions there are two links to required steps that could be easily overlooked:
In addition, The DESIGN.md page has a link to a non-existent 'variables' section (https://github.com/swcarpentry/workshop-template/blob/gh-pages/DESIGN.md#variables) ... perhaps it should be to the variables section of the README.md?
I would suggest
Also