swcarpentry / DEPRECATED-site

DEPRECATED: see https://github.com/swcarpentry/website for the current website.
Other
55 stars 134 forks source link

Broken instructor/bootcamp map #175

Closed ahmadia closed 10 years ago

ahmadia commented 10 years ago

Sorry for the noise in @BernhardKonrad's https://github.com/swcarpentry/site/pull/168. I believe this is a new issue we need to fix.

(Comments from @BernhardKonrad)

I'm sorry, but I spoke too soon. I'm not sure how the LatLng is obtained automatically. Maybe all that needs to be done is updating the corresponding github page: https://github.com/adina/2014-01-08-iastate To avoid future problems like this, it would be nice to change TBD to something that does not pass {% if bootcamp.latlng %} in bootcamp/bootcamp_index.html, or change TBD to a default address. Again, I don't know where the TBD come from exactly...Help!

gvwilson commented 10 years ago

On 2013-10-20 8:48 PM, Aron Ahmadia wrote:

Sorry for the noise in @BernhardKonrad https://github.com/BernhardKonrad's #168 https://github.com/swcarpentry/site/pull/168. I believe this is a new issue we need to fix.

(Comments from @BernhardKonrad https://github.com/BernhardKonrad)

I'm sorry, but I spoke too soon. I'm not sure how the LatLng is
obtained automatically. Maybe all that needs to be done is
updating the corresponding github page:
https://github.com/adina/2014-01-08-iastate
To avoid future problems like this, it would be nice to change TBD
to something that does not pass
{% if bootcamp.latlng %}
in bootcamp/bootcamp_index.html, or change TBD to a default
address. Again, I don't know where the TBD come from exactly...Help!

The TBD appears to be coming from index.html in 2014-01-08-iastate's index.html. I'll send a PR to get the actual location (or something approximating it), and update bin/get_bootcamp_info.py to put an explicit null in for lat/long when the value in the bootcamp page can't be parsed correctly.

BernhardKonrad commented 10 years ago

While we're at it: The python script apparently knows that the workshop is at "Iowa State University", so we could use geocoding from http://py-googlemaps.sourceforge.net/ to get the corresponding LatLng. If that's done automatically already (yet failed for some reason in this case) please disregard this comment.

gvwilson commented 10 years ago

On 2013-10-21 2:40 AM, Bernhard Konrad wrote:

While we're at it: The python script apparently knows that the workshop is at "Iowa State University", so we could use geocoding from http://py-googlemaps.sourceforge.net/ to get the corresponding LatLng. If that's done automatically already (yet failed for some reason in this case) please disregard this comment.

Auto-coding has been unreliable in the past --- particularly for urban universities whose campuses are spread out across the city. (If you geocode "Johns Hopkins", for example, you get the medical campus downtown rather than the science campus where we usually teach.)

ahmadia commented 10 years ago

This appears to have been fixed, but I'm not sure what commit fixed it.

gvwilson commented 10 years ago

On 2013-11-14 10:34 AM, Aron Ahmadia wrote:

This appears to have been fixed, but I'm not sure what commit fixed it.

Work has shifted to #177. cc @BernhardKonrad @drio