search

swcarpentry / good-enough-practices-in-scientific-computing

Minimalist alternatives to "best practices" paper
https://swcarpentry.github.io/good-enough-practices-in-scientific-computing/
Other
157 stars 23 forks source link

Responses to reviewer comments #171

Closed kcranston closed 7 years ago

kcranston commented 7 years ago

First pass at reviewer comments. See also issue #170 and #169

gvwilson commented 7 years ago

:+1:

jennybc commented 7 years ago

Thanks @kcranston. 👍

tracykteal commented 7 years ago

Since there are enough unresolved comments, it doesn't seem like this can be merged. So, I'm going to work in this branch to address the comments and the other ones others have mentioned in the emails.

Let me know if there's an objection to me doing the updates in this branch.

tracykteal commented 7 years ago

Note that a comment thread on an individual line does go away when that section gets updated with new PRs.

gvwilson commented 7 years ago

+1

tracykteal commented 7 years ago

I addressed the issues here, but I also made quite a few other updates. So, I'm going to merge this PR, and then put in a new one.